shenyu0127 commented on code in PR #10604:
URL: https://github.com/apache/pinot/pull/10604#discussion_r1167308201
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java:
##########
@@ -365,11 +380,56 @@ public int[] transformToIntValuesSV(ValueBlock
valueBlock) {
}
}
break;
+ case UNKNOWN:
+ break;
default:
throw new IllegalStateException();
}
}
return _intValuesSV;
}
+
Review Comment:
Had an offline discussion with @61yao
- There is performance improvement if we override
`transformToInValuesSVWithNull` because
- Some subclass's `transformToInValuesSVWithNull` is faster because they
can compute the values and null map together (e.g. CASE WHEN).
- `BaseTransformFunction.transformToInValuesSVWithNull` may call a
non-integer "WithNull" function, which can be a subclass implementation and is
faster.
- The `InTransformFunction.transformToInValuesSV` is long, if we override
`transformToInValuesSVWithNull` with a similar implementation, the repeated
code decreases maintainability. Added a TODO and we will override after
[refactoring](https://github.com/apache/pinot/issues/10618).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
