walterddr commented on code in PR #11592:
URL: https://github.com/apache/pinot/pull/11592#discussion_r1333499258
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -607,6 +607,7 @@ protected BrokerResponse handleRequest(long requestId,
String query, @Nullable S
int numUnavailableSegments = unavailableSegments.size();
requestContext.setNumUnavailableSegments(numUnavailableSegments);
+ boolean isPartialResult = false;
Review Comment:
what is the "partial result" definition? for example if grouplimits reached
for order by queries do we consider that as partial results?
i guess the question is what's the border between
1. result is correct
2. result is correct but we didn't look at the entire table (e.g. `select *
limit 1000`)
3. result is not correct but each row is correct (e.g. `select ... group by
key order by COUNT(*)`)
4. result is not correct, some rows might be correct some rows might not due
to data size limit (`select ... join ... group by ...` when join hits maxRow
limit, grouping result might be partial)
5. result is incorrect (we shouldn't return in this case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
