saurabhd336 commented on code in PR #11592:
URL: https://github.com/apache/pinot/pull/11592#discussion_r1361702468
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java:
##########
@@ -159,11 +164,14 @@ protected BrokerResponseNative processBrokerRequest(long
requestId, BrokerReques
}
int numServersNotResponded = serversNotResponded.size();
if (numServersNotResponded != 0) {
- brokerResponse.setPartialResult(true);
brokerResponse.addToExceptions(new
QueryProcessingException(QueryException.SERVER_NOT_RESPONDING_ERROR_CODE,
String.format("%d servers %s not responded", numServersNotResponded,
serversNotResponded)));
_brokerMetrics.addMeteredTableValue(rawTableName,
BrokerMeter.BROKER_RESPONSES_WITH_PARTIAL_SERVERS_RESPONDED, 1);
}
+ if (totalServersFailedOrNotResponded > 0) {
Review Comment:
@Jackie-Jiang @walterddr This was added to make sure any exceptions in the
returned dataTable (even if the server has responded with a valid set of rows),
are also flagged as potentially partial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
