siddharthteotia commented on code in PR #11592:
URL: https://github.com/apache/pinot/pull/11592#discussion_r1346103624
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -607,6 +607,7 @@ protected BrokerResponse handleRequest(long requestId,
String query, @Nullable S
int numUnavailableSegments = unavailableSegments.size();
requestContext.setNumUnavailableSegments(numUnavailableSegments);
+ boolean isPartialResult = false;
Review Comment:
I think general definition (and this is what we did in the current engine
IIRC) is that partialResults flag would be set to true in either of the
following:
- Result is incomplete (determined by server based on things like GROUP BY
heuristics, threshold etc)
- Not all servers queried responded (determine by broker)
Basically when we are able to determine that there was more data to be
processed but we couldn't either because of our own algorithms (heuristics /
thresholds etc) or failed to hear back from servers.
I think (1) can also be determined by broker during merge.
For SELECT with ORDER BY, I don't think we ever set `partialResults` on
server and there is no need imo.
For SELECT without ORDER BY, servers do early termination based on LIMIT N,
but again partialResults is not set and there is no need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
