walterddr commented on code in PR #11592:
URL: https://github.com/apache/pinot/pull/11592#discussion_r1360838127
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java:
##########
@@ -159,11 +164,14 @@ protected BrokerResponseNative processBrokerRequest(long
requestId, BrokerReques
}
int numServersNotResponded = serversNotResponded.size();
if (numServersNotResponded != 0) {
- brokerResponse.setPartialResult(true);
brokerResponse.addToExceptions(new
QueryProcessingException(QueryException.SERVER_NOT_RESPONDING_ERROR_CODE,
String.format("%d servers %s not responded", numServersNotResponded,
serversNotResponded)));
_brokerMetrics.addMeteredTableValue(rawTableName,
BrokerMeter.BROKER_RESPONSES_WITH_PARTIAL_SERVERS_RESPONDED, 1);
}
+ if (totalServersFailedOrNotResponded > 0) {
Review Comment:
why do we need this? we can simply do
```suggestion
if (numServersQueried - numServersResponded > 0) {
```
if there's any exception inside the response, i thought the broker reducer
is going to rectify and add proper partial result or failure inside?
for example if it is a `SELECT * FROM tbl LIMIT 10` then
- original logic: selection reducer will not tag partial response as long as
there's 1 server returns more than 10 rows
- in this PR: it will tag as long as 1 server returns an exception
is that the intention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
