saurabhd336 commented on code in PR #11592:
URL: https://github.com/apache/pinot/pull/11592#discussion_r1345614546
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -607,6 +607,7 @@ protected BrokerResponse handleRequest(long requestId,
String query, @Nullable S
int numUnavailableSegments = unavailableSegments.size();
requestContext.setNumUnavailableSegments(numUnavailableSegments);
+ boolean isPartialResult = false;
Review Comment:
@walterddr my idea with this flag is to generally cover all cases where we
do sent a response back (no failures), but we also know either some segments /
servers were not queried (segment unavailability / server down etc) or some
rows / groups were ignored.
1) result is correct (this is no flag)
2) result is correct but we didn't look at the entire table (e.g. select *
limit 1000) -> I don't think this should be flagged as partial result since the
result is correct, we don't have to look the entire table up
3) result is not correct but each row is correct (e.g. `select ... group by
key order by COUNT(*)`) -> I'm not sure if there is a way of knowing this in
the current server -> broker response? If yes, then I do think we should flag
this a partial result. I may not have full context, but is it the trimming of
cross segment groups to `max(limit * 5, DEFAULT_MIN_NUM_GROUPS)` that you're
referring to?
4) result is not correct, some rows might be correct some rows might not due
to data size limit (select ... join ... group by ... when join hits maxRow
limit, grouping result might be partial) -> Yes this should classify as
partialResponse imo
5) result is incorrect (we shouldn't return in this case) -> What do you
mean by incorrect here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
