merlimat commented on a change in pull request #12: package logrus for project
URL: https://github.com/apache/pulsar-client-go/pull/12#discussion_r284927911
##########
File path: perf/perf-producer.go
##########
@@ -109,7 +109,7 @@ func produce() {
Payload: payload,
}, func(msgID pulsar.MessageID, message
*pulsar.ProducerMessage, e error) {
if e != nil {
- log.WithError(e).Fatal("Failed to
publish")
+ log.Fatalf("failed to publish: %+v", e)
Review comment:
The purpose of that is to have a way to extract semi-structured information
from the logs, if the application desire to do so. Eg: it could be configured
to write logs as JSON. In that case all the fields will be preserved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
