merlimat commented on a change in pull request #12: package logrus for project
URL: https://github.com/apache/pulsar-client-go/pull/12#discussion_r284929477
##########
File path: pulsar/impl_partition_producer.go
##########
@@ -152,10 +149,10 @@ func (p *partitionProducer) grabCnx() error {
}
p.cnx = res.Cnx
p.cnx.RegisterListener(p.producerId, p)
- p.log.WithField("cnx", res.Cnx).Debug("Connected producer")
+ log.Debugf("connected producer [%s] cnx is: %+v", *p.producerName,
res.Cnx)
Review comment:
Why lose the clean way of attaching the context?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
