merlimat commented on a change in pull request #12: package logrus for project
URL: https://github.com/apache/pulsar-client-go/pull/12#discussion_r284971471
##########
File path: pulsar/internal/lookup_service.go
##########
@@ -81,7 +81,7 @@ func (ls *lookupService) Lookup(topic string)
(*LookupResult, error) {
return nil, err
}
- log.WithField("topic", topic).Debugf("Got topic lookup
response: %s", res)
+ log.Debugf("got topic: %s lookup response: %s", topic, res)
Review comment:
I think it makes it much easier to be consistent (adding `topic=xyz` in same
format for each log message) and also allows for structured logs, if desired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
