merlimat commented on a change in pull request #12: package logrus for project
URL: https://github.com/apache/pulsar-client-go/pull/12#discussion_r284972222
##########
File path: pulsar/impl_partition_producer.go
##########
@@ -134,7 +131,7 @@ func (p *partitionProducer) grabCnx() error {
})
if err != nil {
- p.log.WithError(err).Error("Failed to create producer")
+ log.Errorf("create producer [%s] error: %+v", *p.producerName,
err)
Review comment:
In the above example, the topic name was already set in the `p.log` context
and got missing in the refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
