merlimat commented on a change in pull request #12: package logrus for project
URL: https://github.com/apache/pulsar-client-go/pull/12#discussion_r284928055
##########
File path: perf/pulsar-perf-go.go
##########
@@ -31,12 +30,6 @@ type ClientArgs struct {
var clientArgs ClientArgs
func main() {
- log.SetFormatter(&log.TextFormatter{
- FullTimestamp: true,
- TimestampFormat: "15:04:05.000",
- })
- log.SetLevel(log.InfoLevel)
-
Review comment:
This is how an application configures the logging. The logger configuration
should not be done in `pulsar-client-go` which is a library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
