shibd commented on code in PR #258:
URL:
https://github.com/apache/pulsar-client-node/pull/258#discussion_r1042230580
##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -90,8 +90,8 @@ jobs:
- name: Build Node binaries lib
run: |
yarn install --ignore-scripts
Review Comment:
> Any motivation to make this change?
Please refer this PR `Motivation`
> Since we only cache for npm above:
Thanks for the reminder, should change to cache yarn here.
##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -90,8 +90,8 @@ jobs:
- name: Build Node binaries lib
run: |
yarn install --ignore-scripts
Review Comment:
> Any motivation to make this change?
Please refer this PR `Motivation`
> Since we only cache for npm above:
Thanks for the reminder, should change to cache yarn here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
