shibd commented on code in PR #258:
URL: 
https://github.com/apache/pulsar-client-node/pull/258#discussion_r1043257736


##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -90,8 +90,8 @@ jobs:
       - name: Build Node binaries lib
         run: |
           yarn install --ignore-scripts

Review Comment:
   > Thanks for the reminder, should change to cache yarn here.
   
   @tisonkun I didn't change to using `yarn` cache because using `yarn` cache 
requires a `yarn.lock` file. Referring to this 
[comment](https://github.com/apache/pulsar-client-node/pull/258#issuecomment-1342579551),
 we don't add yarn.lock.
   
   For this compilation step, I chose not to use a cache.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to