shibd commented on code in PR #258:
URL: 
https://github.com/apache/pulsar-client-node/pull/258#discussion_r1042231727


##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -89,9 +89,9 @@ jobs:
 
       - name: Build Node binaries lib
         run: |
-          npm install --ignore-scripts
-          npx node-pre-gyp configure --target_arch=${{ matrix.arch }}
-          npx node-pre-gyp build --target_arch=${{ matrix.arch }}
+          yarn install --ignore-scripts

Review Comment:
   In fact, used npm install when building windows and Linux Arch. Then, I 
changed to using `yarn` when compiling macOS. This has verified that both yarn 
and npm can be used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to