shibd commented on PR #258: URL: https://github.com/apache/pulsar-client-node/pull/258#issuecomment-1342579551
> Not sure whether should we add two lock files for both `npm` and `yarn`. When I ran `yarn install` in my local env, there was a warning: > > ```shell > $ yarn install --no-scripts > yarn install v1.22.19 > warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json. > ``` > > After the `yarn install` command is done, the `yarn.lock` file changed a lot: > > ```shell > $ git diff yarn.lock | wc -l > 7082 > ``` You are right. For developers, we should only use one way to manage dependencies. I remove `yarn.lock`. BTW: For users, It can optionally use `yarn` or `npm`. So, currently, we are not uploading package.lock.json to the npm repository. In this PR, we verified the installation method using yarn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
