tisonkun commented on code in PR #258:
URL:
https://github.com/apache/pulsar-client-node/pull/258#discussion_r1043266963
##########
.github/workflows/ci-pr-validation.yml:
##########
@@ -58,7 +58,6 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.nodejs }}
- cache: 'npm'
Review Comment:
If we choose to check in the npm lock file, it's strange that we run CI
tasks with `yarn`.
What if moving the pkg manager to `yarn` totally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
