BewareMyPower commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1099551784
########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: Actually `load_test.js` should not be named as "xxx_test.js`. It does not "test" anything. It's just a very trivial example script that creates a `Client` object and closes it. A script (`load-test.sh`) that tries to run that Node.js script (`load-test.py`) in a specific environment should be treated as "test" (test if `xxx.js` can run with the Node.js client installed in a specific env) There is a similar case: https://github.com/apache/pulsar-client-cpp/tree/main/win-examples I named it with "xxx-example", which is not a test. However, the following commands (only in the workflow) are the actual test. https://github.com/apache/pulsar-client-cpp/blob/0631e366708fefff399a6d224674428a048e8d37/.github/workflows/ci-pr-validation.yaml#L188-L206 ########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: Actually `load_test.js` should not be named as "xxx_test.js". It does not "test" anything. It's just a very trivial example script that creates a `Client` object and closes it. A script (`load-test.sh`) that tries to run that Node.js script (`load-test.py`) in a specific environment should be treated as "test" (test if `xxx.js` can run with the Node.js client installed in a specific env) There is a similar case: https://github.com/apache/pulsar-client-cpp/tree/main/win-examples I named it with "xxx-example", which is not a test. However, the following commands (only in the workflow) are the actual test. https://github.com/apache/pulsar-client-cpp/blob/0631e366708fefff399a6d224674428a048e8d37/.github/workflows/ci-pr-validation.yaml#L188-L206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
