BewareMyPower commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1102446380
########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: It's very clear that: - `pkg/` directiory contains scripts that package the Node.js binaries in various operation systems. - `src/` directory containes source code - `docs/` directory contains documents - `example/` directory contains examples - `tests/` directory contains tests I do not know why do you so insist on distributing tests to different directories. Some languages tend to put tests under the same directory with the code to test, like Golang, the source code directory contains `xxx.go` and the associated test `xxx_test.go`. It seems that your logic looks like that: the tests (`load-test.sh`) for package scripts should be put under the same directory (`pkg/linux/*.sh`). However, Node.js is different with those languages. Just like Java, the tests for source code (`src/`) are put under a separated directory (`tests/`). If you changed the rule, the for users new to this project, it's not clear to know tests are distributed into how many directories.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
