BewareMyPower commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1099841274
########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: My perspective is, `tests` directory groups all tests into one directory, including: 1. Tests for the `src/` directory. 2. Tests for the `pkg/` directory. 3. ... If we have some shell scripts in other directories like `bin/`, the tests for them could also be put under the `tests` directory. Actually I want to move the `load_test.js` into the `tests` directory, but I want to avoid unnecessary project structure changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
