shibd commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1099596237
########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: > Actually load_test.js should not be named as "xxx_test.js". It does not "test" anything. It's just a very trivial example script that creates a Client object and closes it. Yes, It is to test whether the binary package is usable, not unit testing. Similarly, `./tests/load-test.sh` and `docker-load-test.sh` also test whether the binary package can be used(Multi-platform under Linux). They are all part of the compilation process, so I recommend putting them in the `pkg` directory IMO, That only unit test-related files should be placed in the `tests` directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
