BewareMyPower commented on code in PR #288: URL: https://github.com/apache/pulsar-client-node/pull/288#discussion_r1102464620
########## tests/load-test.sh: ########## @@ -0,0 +1,42 @@ +#!/bin/bash Review Comment: I realized https://github.com/apache/pulsar-client-python/blob/main/pkg/test-wheel.sh might inspire you to put scripts under the `pkg/` directory. I don't think it's a good practice. First, in this script, `/pulsar-client-python/wheelhouse/pulsar_client-*.whl` should be the paths inside a docker container. This script cannot be executed locally. It's more like the `docker-load-test.sh` in this PR. However, the path of `docker-load-test.sh` is not related to the Dockerfile under `pkg/linux`. Instead, the path of `/pulsar-client-node/build/Release/pulsar.node` and `/pulsar-client-node/pulsar-client-node.tar.gz` are created by `load-test.sh`, not the `pkg/linux/Dockerfile_linux_glibc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
