rdhabalia commented on a change in pull request #1904: Introduce kinesis sink
on function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193217251
##########
File path: pulsar-broker/pom.xml
##########
@@ -274,6 +274,14 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
right now, it seems we don't have unit test which can test pulsar-broker and
pulsar-function. having this e2e test help to find out many unknown issues and
also help testing while development. we also have admin-rest-api for functions
at pulsar-broker module for which we don't have test. so, this will be used to
add e2e test which can cover all those code paths.
> if you need some test cases from pulsar-broker, it would be much better
that pulsar-broker generates a test-jar.
umm.. not exactly. as I explained above, the idea is to start mock broker
and fun-worker and test kinesis-sink there. so, we might not be able to write
it at kinesis-sink module.
Hope that make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
