rdhabalia commented on a change in pull request #1904: Introduce kinesis sink
on function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193856135
##########
File path: pulsar-broker/pom.xml
##########
@@ -274,6 +274,14 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
> This one just breaks the broker abstraction.
Umm..But function also depends on broker for the execution. so, e2e test
will require broker init it. and adding test will not impact any code level
abstraction. ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
