rdhabalia commented on a change in pull request #1904: Introduce kinesis sink
on function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193854032
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -465,6 +465,7 @@ public void setupInput() throws Exception {
if (sourceSpec.getClassName().isEmpty()) {
PulsarSourceConfig pulsarSourceConfig = new PulsarSourceConfig();
pulsarSourceConfig.setTopicSerdeClassNameMap(sourceSpec.getTopicsToSerDeClassNameMap());
+ pulsarSourceConfig.setTopicsPattern(sourceSpec.getTopicsPattern());
Review comment:
@jerrypeng
yes, I have rebased the change and now, we should not see any overlap here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
