rdhabalia commented on a change in pull request #1904: Introduce kinesis sink
on function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193250599
##########
File path: pulsar-broker/pom.xml
##########
@@ -274,6 +274,14 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
> image you are a connector developer, you develop a connector system xyz.
are you expecting to put this connector into broker module and test it?
Make sense. Actually, I was trying to add e2e test for broker + function
which we don't have and I picked up kinesis-sink in test-case as an example.
may be I can replace kinesis-sink with pulsar-sink to keep it more generic e2e
test. will that be fine?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
