rdhabalia commented on a change in pull request #1904: Introduce kinesis sink
on function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193854225
##########
File path: pulsar-broker/pom.xml
##########
@@ -274,6 +274,14 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
@sijie I have added `PulsarSinkTest` . However, I feel keeping
Kinesis-Connector e2e test is not harmful as it's just a test and
dependency-scope is also test. I think it is helping to add more test
code-coverage in pulsar-function where existing testcases are not touching some
of the code paths. We can definitely remove it in future and only keep
PulsarSinkTest if it is causing any issue for dependency management but until
we can keep it as it will be helpful for future development testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
