rdhabalia commented on a change in pull request #1904: Introduce kinesis sink
on function
URL: https://github.com/apache/incubator-pulsar/pull/1904#discussion_r193880663
##########
File path: pulsar-broker/pom.xml
##########
@@ -274,6 +274,14 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
actually, in order to add it individual source/sink, we need to adapt broker
and functions mock-service tests into those individual modules. Pulsar-broker
starts services for broker, websocket, proxy and functions as well so, we have
kept all e2e tests for services into broker-modules and no need to copy mocks
at individual service level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
