sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r199938472
##########
File path:
tests/integration/semantics/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTestBase.java
##########
@@ -50,8 +50,8 @@ protected static String getExclamationClass(Runtime runtime)
{
}
@BeforeClass
- public static void setupCluster() throws Exception {
- PulsarClusterTestBase.setupCluster();
+ public void setupCluster() throws Exception {
Review comment:
what do you mean they can instantiate class instance? when you switch from
static method to class method, you are setting up and tearing down clusters for
each test method, which is not necessary. unless there is a strong reason to do
that, I would prefer not changing that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
