sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200020837
##########
File path:
tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/containers/PulsarContainer.java
##########
@@ -81,10 +82,11 @@ public void start() {
this.waitStrategy = new HostPortWaitStrategy()
.withStartupTimeout(Duration.of(300, SECONDS));
}
+ this.withLogConsumer(new Slf4jLogConsumer(log).withPrefix(hostname));
Review comment:
an Slf4jLogConsumer might be helpful if it is a standalone container. but it
doesn't help when running testcontainers in a cluster mode. it actually make
things a bit worse. so I would prefer put this under a flag (either system
environment or system property). e.g `enableSlf4jLogConsumer`.
so people can enable it when running locally, and we can disable it on CI.
on CI we should use what @ivankelly has implemented on dumping container logs
on tests completed (I am porting that behavior to testcontainers at #2076 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
