sijie commented on a change in pull request #2078: Enhance Pulsar cluster with 
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r199945641
 
 

 ##########
 File path: 
tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java
 ##########
 @@ -84,13 +98,17 @@ private PulsarCluster(PulsarClusterSpec spec) {
             .withEnv("pulsarNode", "pulsar-broker-0");
 
         this.csContainer = new CSContainer(clusterName)
+            .withLogConsumer(new 
Slf4jLogConsumer(log).withPrefix(CSContainer.NAME))
 
 Review comment:
   you seem to enable log consumer at every container. this should be done at 
the common container class, rather than spreading it everywhere.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to