sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r199943910
##########
File path:
tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarClusterTestBase.java
##########
@@ -56,19 +57,15 @@
protected static PulsarCluster pulsarCluster;
@BeforeClass
- public static void setupCluster() throws Exception {
- StringBuilder sb = new StringBuilder();
- for (int i = 0; i < 8; i++) {
- sb.append((char) (ThreadLocalRandom.current().nextInt(26) + 'a'));
- }
+ public void setupCluster() throws Exception {
PulsarClusterSpec spec = PulsarClusterSpec.builder()
- .clusterName(sb.toString())
+ .clusterName(this.getClass().getSimpleName())
Review comment:
it has - if you tied to class name, that means you can only have one test
running with that given class. in a CI environment, this will tend to break. if
you want to improve the identification part, use the class name + the existing
randomized string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
