sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r199944667
##########
File path:
tests/integration/semantics/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTestBase.java
##########
@@ -50,8 +50,8 @@ protected static String getExclamationClass(Runtime runtime)
{
}
@BeforeClass
- public static void setupCluster() throws Exception {
- PulsarClusterTestBase.setupCluster();
+ public void setupCluster() throws Exception {
Review comment:
fine, but why do you change it from static method to class method?
if you do have a strong reason, please describe the reason in your pull
request. otherwise it is hard for reviewers to understand why these are changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
