rmatharu commented on a change in pull request #1021: Adding writing of
container.metadata file, and moving exception writing logic to
DiagnosticsManager
URL: https://github.com/apache/samza/pull/1021#discussion_r282177357
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
##########
@@ -141,6 +143,9 @@ object SamzaContainer extends Logging {
val systemConfig = new SystemConfig(config)
val containerModel = jobModel.getContainers.get(containerId)
val containerName = "samza-container-%s" format containerId
+ val jobName = config.getName.getOrElse(throw new ConfigException("Missing
required config: job.name"))
Review comment:
After https://github.com/apache/samza/pull/920/files
the planner enforces job and app name to be the same,
so yes, by the time we land in Samza Container we would've already check
both configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
