rmatharu commented on a change in pull request #1021: Adding writing of 
container.metadata file, and moving exception writing logic to 
DiagnosticsManager
URL: https://github.com/apache/samza/pull/1021#discussion_r284378234
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala
 ##########
 @@ -114,6 +114,10 @@ object JobConfig {
   val DEFAULT_STANDBY_TASKS_REPLICATION_FACTOR = 1
   val SYSTEM_STREAM_PARTITION_MAPPER_FACTORY = 
"job.system.stream.partition.mapper.factory"
 
+  // Naming format and directory for container.metadata file
+  private val CONTAINER_METADATA_FILENAME_FORMAT = "%s.metadata" // Filename: 
<containerID>.metadata
+  private val CONTAINER_METADATA_DIRECTORY_SYS_PROPERTY = "samza.log.dir"
 
 Review comment:
   This is already existing. This is just defining the constant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to