rmatharu commented on a change in pull request #1021: Adding writing of
container.metadata file, and moving exception writing logic to
DiagnosticsManager
URL: https://github.com/apache/samza/pull/1021#discussion_r282669146
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -219,6 +220,11 @@ public void run() {
//initialize JobCoordinator state
LOG.info("Starting cluster based job coordinator");
+ // write the diagnostics metadata file
+ Optional<String> execEnvContainerId =
Optional.ofNullable(System.getenv("CONTAINER_ID"));
Review comment:
Is there a better way of obtaining this?
In AM the yarn-containerID is in env variable CONTAINER_ID whereas on
containers it is under
EXEC_ENV_CONTAINER_ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
