rmatharu commented on a change in pull request #1021: Adding writing of
container.metadata file, and moving exception writing logic to
DiagnosticsManager
URL: https://github.com/apache/samza/pull/1021#discussion_r284371862
##########
File path: samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala
##########
@@ -96,11 +96,6 @@ class TaskConfig(config: Config) extends
ScalaMapConfig(config) with Logging {
case _ => TaskConfig.DEFAULT_COMMIT_MS
}
- def getShutdownMs: Option[Long] = getOption(TaskConfig.SHUTDOWN_MS) match {
Review comment:
This was duplicated between TaskConfig.scala and TaskConfigJava.java
(there is duplication between these, Im working parallely on removing)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
