rmatharu commented on a change in pull request #1021: Adding writing of container.metadata file, and moving exception writing logic to DiagnosticsManager URL: https://github.com/apache/samza/pull/1021#discussion_r284377346
########## File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java ########## @@ -23,16 +23,25 @@ import org.apache.samza.config.ClusterManagerConfig; import org.apache.samza.config.Config; import org.apache.samza.config.JobConfig; +import org.apache.samza.config.MetricsConfig; import org.apache.samza.coordinator.JobModelManager; import org.apache.samza.coordinator.stream.messages.SetContainerHostMapping; +import org.apache.samza.diagnostics.DiagnosticsManager; import org.apache.samza.metrics.ContainerProcessManagerMetrics; +import org.apache.samza.metrics.JvmMetrics; import org.apache.samza.metrics.MetricsRegistryMap; +import org.apache.samza.metrics.MetricsReporter; +import org.apache.samza.metrics.reporter.MetricsSnapshotReporter; +import org.apache.samza.util.DiagnosticsUtil; +import org.apache.samza.util.MetricsReporterLoader; import org.apache.samza.util.Util; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.util.HashMap; import java.util.List; import java.util.Map; +import scala.Option; +import scala.Tuple2; Review comment: org.apache.commons.lang3.tuple.Pair seems more useful than the rest (javafx seems like something to avoid) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
