prateekm commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r289121521
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java
##########
@@ -51,9 +51,13 @@
* Config and derived config objects
*/
private final TaskConfig taskConfig;
-
private final Config config;
+ /**
+ * Classloader for creating objects from config
+ */
+ private final ClassLoader classLoaderForConfigObjects;
Review comment:
Is there a more specific name for this? E.g. user/framework/plugin
classloader etc? Maybe call this and the method params pluginClassloader?
If not, does it make sense to just call this classloader? I think all the
classloaders are used for loading configured classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
