prateekm commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290062872
##########
File path:
samza-azure/src/main/java/org/apache/samza/coordinator/AzureJobCoordinator.java
##########
@@ -298,8 +298,9 @@ private SchedulerStateChangeListener
createLeaderLivenessListener() {
private SystemStreamPartitionGrouper getSystemStreamPartitionGrouper() {
JobConfig jobConfig = new JobConfig(config);
String factoryString = jobConfig.getSystemStreamPartitionGrouperFactory();
- SystemStreamPartitionGrouper grouper = Util.getObj(factoryString,
SystemStreamPartitionGrouperFactory.class)
- .getSystemStreamPartitionGrouper(jobConfig);
+ SystemStreamPartitionGrouper grouper =
Review comment:
Yeah, doing the wiring later is fine. My question is more about the naming
for readability. For someone looking at these classes in isolation (i.e.
outside these PRs), would it be cleaner to call these fwk / plugin classloaders
explicitly?
If I understand your point correctly, what you're saying is that once the
wiring is done they will not need to know since it will just work with the
following rule: if a classloader param / field is available, use it, else use
your own classloader. Is that correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
