prateekm commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290063549
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -94,7 +95,7 @@
public LocalApplicationRunner(SamzaApplication app, Config config) {
this.appDesc = ApplicationDescriptorUtil.getAppDescriptor(app, config);
isAppModeBatch = new ApplicationConfig(config).getAppMode() ==
ApplicationConfig.ApplicationMode.BATCH;
- coordinationUtils = getCoordinationUtils(config);
+ coordinationUtils = getCoordinationUtils(config,
getClass().getClassLoader());
Review comment:
Sorry for confusion, my point was that at this point this is currently the
framework classloader, but needs to be the plugin classloader. Naming it
accordingly will help use the right one later.
I think what you're saying is that this will be addressed in the next PR,
and that's a better place to look for "using the appropriate classloader"
issues. If so, this is fine as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
