prateekm commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290026667
##########
File path:
samza-azure/src/main/java/org/apache/samza/coordinator/AzureJobCoordinator.java
##########
@@ -298,8 +298,9 @@ private SchedulerStateChangeListener
createLeaderLivenessListener() {
private SystemStreamPartitionGrouper getSystemStreamPartitionGrouper() {
JobConfig jobConfig = new JobConfig(config);
String factoryString = jobConfig.getSystemStreamPartitionGrouperFactory();
- SystemStreamPartitionGrouper grouper = Util.getObj(factoryString,
SystemStreamPartitionGrouperFactory.class)
- .getSystemStreamPartitionGrouper(jobConfig);
+ SystemStreamPartitionGrouper grouper =
Review comment:
Shouldn't the JC be using the plugin classloader for loading these
components? Or is the JC considered a "plugin" itself and is loaded using the
plugin classloader?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
