prateekm commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290037838
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -507,7 +518,8 @@ private StorageEngine createStore(String storeName,
TaskName taskName, TaskModel
.orElseThrow(() -> new SamzaException(
String.format("Could not find side inputs processor
factory for store: %s", storeName)));
sideInputStoresToProcessors.get(taskName)
- .put(storeName,
Util.getObj(sideInputsProcessorFactoryClassName,
SideInputsProcessorFactory.class)
+ .put(storeName, ReflectionUtil.getObj(classLoader,
sideInputsProcessorFactoryClassName,
Review comment:
Minor, unrelated: Let's extract the side inputs processor as a local
variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
