nielifeng opened a new pull request, #11464:
URL: https://github.com/apache/seatunnel/pull/11464
### Purpose of this pull request
Fixes #11463.
This PR fixes `LogUtil.getLogPath()` using the routing appender path to
calculate the substring index for the file appender path. With a
file-appender-only Log4j2 configuration, the routing path is `null` and log
REST endpoints fail with a `NullPointerException`.
It also adds a regression test using a file-appender-only configuration.
### Does this PR introduce _any_ user-facing change?
Yes. Zeta log path resolution now works when only `fileAppender` is
configured, so log REST endpoints can access the configured log directory
instead of failing with a `NullPointerException`.
### How was this patch tested?
Added `LogUtilTest.shouldGetLogPathFromFileAppender` and ran:
```shell
./mvnw -o -pl seatunnel-engine/seatunnel-engine-common -Dtest=LogUtilTest
-Dskip.spotless.check=true -Dcheckstyle.skip=true test
```
The test fails with a `NullPointerException` on the previous implementation
and passes with this fix.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
