nielifeng commented on PR #11464: URL: https://github.com/apache/seatunnel/pull/11464#issuecomment-5032179676
Addressed the latest review feedback in commit `34b62c41a`: - isolated `LogUtilTest` from the shared global `LoggerContext`; - resolved parent directories with `Paths.get(...).getParent()`, including a `.` fallback for path-less file names and a descriptive null/blank-path error; - added routing-appender and empty/path-less path coverage; - moved the file-only test output under the JVM temp directory; - aligned the ASF header and assertion style. Validation: - `LogUtilTest`: 4 tests passed; - `seatunnel-engine-common -DskipTests verify`: passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
