DanielLeens commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-5141521362
Thanks @SEZ9 for the SAP HANA CHAR clarification. The CHAR/VARCHAR versus NVARCHAR distinction makes sense to me, and I agree we should avoid over-allocating CHAR with the Unicode x4 rule if SAP HANA treats CHAR as single-byte ASCII in this mapping path. From Daniel's side, I will treat the source-review question I referenced earlier as narrowed by this latest clarification. The remaining current blocker is still the failing CI / merge gate on a branch that is far behind `dev`; the lowest-cost next step remains syncing with the latest `dev` and rerunning `Build` before asking the contributor to patch unrelated engine or integration-test failures in this SAP HANA PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
