DanielLeens commented on PR #11648: URL: https://github.com/apache/seatunnel/pull/11648#issuecomment-5379381903
Thanks for chasing this down with @davidzollo, and glad the seatunnel-shade split path is now clear. Splitting the two shade poms out to apache/seatunnel-shade#20 and keeping this PR to the remaining ~85 files (connector-file-s3, connector-file-oss, seatunnel-dist, seatunnel-e2e, checkpoint-storage-hdfs, imap-storage-file, docs) is the right move. One nice side effect: with the shade module gone from this PR's scope, the `seatunnel-hadoop3-3.1.4-uber` -> `seatunnel-hadoop3-3.4.3-uber` rename goes with it, so the `incompatible-changes.md` entry that existed only to document that rename should no longer be needed here either -- worth confirming during the rebase, but I don't see anything else left in this PR's scope that would still qualify as a breaking change. My "Ready to merge" approval on `5799a570` was for the pre-split head, which still contained the shade changes and the module rename, so it doesn't carry over automatically to whatever this PR looks like once it's rebased on top of the split with `3.4.3-3.0.0` published for the shade artifacts. I'll do a fresh full review once you push that update -- happy to take another close look at the E2E/dist wiring once the module split lands. No opinion from me on the shade release cadence, that's really a question for @davidzollo / the seatunnel-shade maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
