SEZ9 commented on PR #11648: URL: https://github.com/apache/seatunnel/pull/11648#issuecomment-5381238802
Thanks @DanielLeens for confirming the `benchmark-test` job on `5799a5700` came back green on both JDK 8 and JDK 11 — with that resolved, the review side of the Hadoop 3.4.3 / AWS SDK v2 migration looks complete to me as well. That said, per @davidzollo's note, `seatunnel-shade` now lives in a separate repository and is consumed as a jar dependency, and #9993 has been merged on `dev`. So before we can merge, the remaining concrete asks are: 1. Please split the shade-side changes (`seatunnel-shade/pom.xml`, `seatunnel-shade/seatunnel-hadoop-aws/pom.xml`, and the `seatunnel-hadoop3-3.1.4-uber` → 3.4.3 module bump) out of this PR and submit them against apache/seatunnel-shade, following the shade guide linked above. 2. Rebase this PR onto the current `dev` (post-#9993) so the remaining changes here — primarily the connector doc updates for the new jar name and the v2 provider classes (`org.apache.hadoop.fs.s3a.auth.IAMInstanceCredentialsProvider`, `software.amazon.awssdk.auth.credentials.AwsCredentialsProvider`) — apply cleanly against the new dependency setup. 3. Since dropping the v1 `aws-java-sdk-bundle` is a user-visible breaking change for anyone with `com.amazonaws.*` provider class names in existing job configs, please make sure the updated Hive, OssFile and S3File docs include an explicit migration note calling that out. This was the open item from my earlier review and I'd like to see it addressed before merge. Non-blocking: the misleading comment about the `hadoop-aliyun.version` override that @DanielLeens flagged can stay as a follow-up nit for a later pass. Thanks again for the thorough work here — once the split and the doc migration note are in place, this should be good to go. <!-- streview-comment:452 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
