DanielLeens commented on code in PR #11841:
URL: https://github.com/apache/seatunnel/pull/11841#discussion_r3923493873


##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/job/JobImmutableInformation.java:
##########
@@ -167,6 +168,14 @@ public boolean isRestoreJob() {
         return restoreMode != null && restoreMode.isRestore();
     }
 
+    public boolean isSavepointRestore() {

Review Comment:
   Agreed — that matches what I traced independently in my last full pass: 
`JobImmutableInformation` is the job-submission payload only (RPC/REST 
`submitJob`), not part of the checkpoint/savepoint state file itself, and 
`readData()`'s trailer-based fallback (`restoreMode = isStartWithSavePoint ? 
SAVEPOINT : NONE` when no `RestoreMode` trailer exists) already covers a 
payload written by a pre-`RestoreMode` version. No gap here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to