JeremyXin commented on code in PR #11841:
URL: https://github.com/apache/seatunnel/pull/11841#discussion_r3923025372
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -284,7 +285,7 @@ public synchronized void init(long initializationTimestamp,
boolean restart) thr
sink.getId()));
JobMaster.handleSaveMode(
((SinkAction<?, ?, ?, ?>)
sink).getSink(),
- logicalDag.isStartWithSavePoint());
Review Comment:
In the current implementation，`LogicalDag.isStartWithSavePoint` is still
kept for compatibility, but the restore checks outside are now based on
`jobImmutableInformation.getRestoreMode()`.
So this change is mainly about making `JobImmutableInformation` the source
of truth for restore semantics, instead of spreading that logic across both
places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
