DanielLeens commented on code in PR #11841:
URL: https://github.com/apache/seatunnel/pull/11841#discussion_r3923498751
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/BaseService.java:
##########
@@ -1360,7 +1360,7 @@ protected JsonObject submitJobInternal(
new SubmitJobOperation(
Review Comment:
Agreed, and this matches the fallback path I already verified in my last
review (`readData()` derives `restoreMode` from the legacy
`isStartWithSavePoint` field via `hasRemainingBytes(in)` when no `RestoreMode`
trailer is present). Re-deriving inside `CoordinatorService` rather than
trusting the RPC parameter is the right call precisely because it's provably no
worse for old payloads and strictly better for any future caller that might
drift. No compatibility concern here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
